Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the TF NER example #10276

Merged
merged 1 commit into from
Feb 19, 2021
Merged

Move the TF NER example #10276

merged 1 commit into from
Feb 19, 2021
+65 −65

Conversation

jplu
Copy link
Contributor

@jplu jplu commented Feb 19, 2021

What does this PR do?

This PR moves the run_tf_ner.py example into the legacy folder because it uses the "legacy" way to train a model with the utils_ner.py file.

@jplu jplu requested review from sgugger and LysandreJik February 19, 2021 13:29
sgugger
sgugger approved these changes Feb 19, 2021
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We should hopefully have a TF script using the same way of training very soon.

@jplu
Copy link
Contributor Author

jplu commented Feb 19, 2021

Nice! What means "same way of training", same way than what?

@sgugger
Copy link
Collaborator

sgugger commented Feb 19, 2021

Same way as the current run_ner script.

LysandreJik
LysandreJik approved these changes Feb 19, 2021
View reviewed changes
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@LysandreJik LysandreJik merged commit 536aee9 into huggingface:master Feb 19, 2021
@jplu jplu deleted the move-tf-ner branch February 22, 2021 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgugger sgugger sgugger approved these changes

@LysandreJik LysandreJik LysandreJik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jplu @sgugger @LysandreJik