Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bert-base-german-cased] use model repo, not external bucket #10353

Merged
merged 1 commit into from
Feb 23, 2021
Merged

[bert-base-german-cased] use model repo, not external bucket #10353

merged 1 commit into from
Feb 23, 2021

Conversation

julien-c
Copy link
Member

References: #10306

@julien-c julien-c requested a review from LysandreJik February 23, 2021 15:51
@julien-c julien-c mentioned this pull request Feb 23, 2021
Closed
@julien-c julien-c linked an issue Feb 23, 2021 that may be closed by this pull request
Issue Loading bert-based-german-cased #10306
Closed
LysandreJik
LysandreJik approved these changes Feb 23, 2021
View reviewed changes
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@julien-c julien-c merged commit 4a1ab7c into master Feb 23, 2021
@julien-c julien-c deleted the bert-base-german-cased branch February 23, 2021 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LysandreJik LysandreJik LysandreJik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue Loading bert-based-german-cased
2 participants
@julien-c @LysandreJik