Removes overwrites for output_dir #10521
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR removes the overwrites of the
output_dir
when running training onSageMaker
and it removes the automatic save ifoutput_dir
isNone
.The overwrites have been removed since it prevents saving checkpoints to a different dir like
opt/ml/checkpoints
impossible and it is not the "transformers" way. We can keep it the same as running training somewhere else and provide documentation on what you need to do.