Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[examples template] added max_sample args and metrics changes #10602

Merged
merged 1 commit into from
Mar 9, 2021
Merged

[examples template] added max_sample args and metrics changes #10602

merged 1 commit into from
Mar 9, 2021

Conversation

bhadreshpsavani
Copy link
Contributor

@bhadreshpsavani bhadreshpsavani commented Mar 9, 2021

What does this PR do?

This PR adds the same as #10551 and #10436 to the cookie-cutter template.

Fixes #10423

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

review:

@stas00

@stas00 stas00 requested review from sgugger and stas00 March 9, 2021 05:55
Copy link
Contributor

@stas00 stas00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @bhadreshpsavani!

Sorry, I sent you to the wrong part of the cookie-cutter, originally. I should have sent you here instead:
https://github.com/huggingface/transformers/tree/master/templates/adding_a_new_example_script

But I run it and the autogenerated code based on your edits runs just fine.

So all is good.

Thank you!

@stas00 stas00 changed the title added max_sample args and metrics changes [examples template] added max_sample args and metrics changes Mar 9, 2021
@bhadreshpsavani
Copy link
Contributor Author

Ya @stas00,
Actually I figured that and tested visually with the example tamplate not the model template

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for adding this in the template as well!

@sgugger sgugger merged commit ac17f71 into huggingface:master Mar 9, 2021
@bhadreshpsavani bhadreshpsavani deleted the max-cli-and-metrics branch March 9, 2021 17:10
Iwontbecreative pushed a commit to Iwontbecreative/transformers that referenced this pull request Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[examples] add --max_train_samples --max_val_samples --max_test_samples cl args to all scripts
3 participants