Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Flax] Add Electra models #11426
[Flax] Add Electra models #11426
Changes from 4 commits
5b61735
343d61e
1fc055b
53d1835
8d4621e
f536d77
f41e4db
9f96419
283425c
7e7e424
2d19a8c
4fad31d
ef9b4cf
b60c2ff
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add to do this gimmick since the way weight sharing in
FlaxBert
was done doesn't work for Electra and other models since they don't explictly separate the bias from the kernel (as is the case in Bert)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a cool class! However since ELECTRA doesn't tie word embeddings, I don't think we need it at the moment :-) Could we maybe leave it out for now and remove the tie embedding logic in ELECTRA?