Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression in regression #11785

Merged
merged 2 commits into from
May 20, 2021
Merged

Fix regression in regression #11785

merged 2 commits into from
May 20, 2021

Conversation

sgugger
Copy link
Collaborator

@sgugger sgugger commented May 20, 2021

What does this PR do?

This PR fixes the regression introduced in #11012 for regression problems with only one label (like STS-B), see discussion on #11780. I checked both run_glue and run_glue_no_trainer on this branch and get the proper results for this task now.

Fixes #11780
Fixes #11583

@sgugger sgugger requested a review from LysandreJik May 20, 2021 13:23
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, LGTM, thanks!

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the test!

@sgugger sgugger merged commit 469384a into master May 20, 2021
@sgugger sgugger deleted the fix_regression branch May 20, 2021 13:55
@yoshitomo-matsubara
Copy link
Contributor

Thank you for fixing the issue!

Iwontbecreative pushed a commit to Iwontbecreative/transformers that referenced this pull request Jul 15, 2021
* Fix regression in regression

* Add test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants