Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Tensorflow Bart-like positional encoding #11897

Merged
merged 1 commit into from
Jul 13, 2021
Merged

Fix Tensorflow Bart-like positional encoding #11897

merged 1 commit into from
Jul 13, 2021

Conversation

JunnYu
Copy link
Contributor

@JunnYu JunnYu commented May 27, 2021 •
edited
Loading

What does this PR do?

Fixes #11724

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@patrickvonplaten

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@JunnYu JunnYu mentioned this pull request Jun 17, 2021
Closed
@huggingface huggingface deleted a comment from github-actions bot Jul 13, 2021
patrickvonplaten
patrickvonplaten approved these changes Jul 13, 2021
View reviewed changes
Copy link
Contributor

@patrickvonplaten patrickvonplaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@patrickvonplaten patrickvonplaten changed the title fix #11724 Fix Tensorflow Bart-like positional encoding Jul 13, 2021
@patrickvonplaten patrickvonplaten merged commit 4cdb7ee into huggingface:master Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickvonplaten patrickvonplaten patrickvonplaten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A bug in modeling_tf_marian.py and modeling_tf_pegasus.py SinusoidalPositionalEmbedding _init_weight
2 participants
@JunnYu @patrickvonplaten