Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JAX/Flax readme] add philosophy doc #12419

Merged
merged 11 commits into from
Jun 30, 2021

Conversation

patil-suraj
Copy link
Contributor

What does this PR do?

Adds a section about Flax's design philosophy in Transformers.

patil-suraj and others added 2 commits June 30, 2021 16:16
Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com>
Copy link
Contributor

@osanseviero osanseviero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me! I really like the images and overall structure.

I just left a couple of nits. Please capitalize Flax and PyTorch consistently :)

examples/research_projects/jax-projects/README.md Outdated Show resolved Hide resolved
examples/research_projects/jax-projects/README.md Outdated Show resolved Hide resolved
examples/research_projects/jax-projects/README.md Outdated Show resolved Hide resolved
examples/research_projects/jax-projects/README.md Outdated Show resolved Hide resolved
examples/research_projects/jax-projects/README.md Outdated Show resolved Hide resolved
@patil-suraj patil-suraj requested a review from osanseviero June 30, 2021 14:19
Copy link
Contributor

@patrickvonplaten patrickvonplaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, just some minor changes

Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com>
@patil-suraj
Copy link
Contributor Author

Thanks a lot Patrick for the awesome images :)

@patil-suraj patil-suraj merged commit 3f36a2c into huggingface:master Jun 30, 2021
@patil-suraj patil-suraj deleted the flax-in-trfms-readme branch June 30, 2021 16:10
Iwontbecreative pushed a commit to Iwontbecreative/transformers that referenced this pull request Jul 15, 2021
* add philosophy doc

* fix typos

* update doc

* Apply suggestions from code review

Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com>

* address Patricks suggestions

* add a training example and fix typos

* jit the training step

* jit train step

* fix example code

* typo

* Apply suggestions from code review

Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com>

Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants