FlaxGPTNeo #12493
Merged
FlaxGPTNeo #12493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| self.causal_mask = make_causal_mask(jnp.ones((1, config.max_position_embeddings), dtype="bool"), dtype="bool") | ||
| if self.attention_type == "local": | ||
| self.causal_mask = self.causal_mask ^ jnp.tril(self.causal_mask, -config.window_size) |
There was a problem hiding this comment.
maybe an additional comment here would be nice
patrickvonplaten
approved these changes
Jul 5, 2021
LysandreJik
approved these changes
Jul 5, 2021
| prepared_inputs_dict["attention_mask"][batch_idx, :start_index] = 0 | ||
| prepared_inputs_dict["attention_mask"][batch_idx, start_index:] = 1 | ||
| pt_model = pt_model_class(config).eval() | ||
| fx_model = model_class(config, dtype=jnp.float32) |
There was a problem hiding this comment.
Is fx_model a common name for Flax models? It reminds of torch.fx
There was a problem hiding this comment.
Aah, yeah this is confusing. Maybe we could use flx or just flax for flax models. (cc @patrickvonplaten )
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds the Flax version of GPTNeo. For local attention, it uses the fix proposed by @finetuneanon in #11630.
Thanks a lot, @finetuneanon for proposing the solution, it's especially important in JAX/Flax where we can't have dynamic shapes.
Official GPTNeo flax checkpoints are up on the hub and slow tests are passing.