implementing tflxmertmodel integration test #12497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe your version of the code quality tools isn't up to date - can you try running the following at the root of your clone: |
|
Hi @LysandreJik Yep It was my black version |
LysandreJik
reviewed
Jul 5, 2021
tests/test_modeling_tf_lxmert.py
Outdated
| ] | ||
| ] | ||
| ) | ||
| tf.debugging.asset_near(output[:, :3, :3], expected_slice, atol=1e-4) |
There was a problem hiding this comment.
This should be assert_near
Suggested change
| tf.debugging.asset_near(output[:, :3, :3], expected_slice, atol=1e-4) | |
| tf.debugging.assert_near(output[:, :3, :3], expected_slice, atol=1e-4) |
tests/test_modeling_tf_lxmert.py
Outdated
Comment on lines
766
to
911
| [self.model_tester.num_attention_heads, encoder_key_length, self.model_tester.num_visual_features], | ||
| [ | ||
| self.model_tester.num_attention_heads, | ||
| encoder_key_length, | ||
| self.model_tester.num_visual_features, | ||
| ], |
There was a problem hiding this comment.
There's a lot of style changes in your PR - do you think you could only do the changes relative to the code you're adding? Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
this PR implement an integration test for TFLxmertmodel as requested in #9954
@LysandreJik