Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix order of state and input in Flax Quickstart README #12510

Merged
merged 1 commit into from
Jul 5, 2021
Merged

Fix order of state and input in Flax Quickstart README #12510

merged 1 commit into from
Jul 5, 2021

Conversation

navjotts
Copy link
Contributor

@navjotts navjotts commented Jul 5, 2021 •
edited
Loading

What does this PR do?

Correct the order of state and input for flax.linen.apply() in Flax Quickstart README

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).

Who can review?

@patrickvonplaten @patil-suraj

@navjotts
Copy link
Contributor Author

navjotts commented Jul 5, 2021 •
edited
Loading

Note: if the above correction is valid, then we ll need to update this image as well

patil-suraj
patil-suraj approved these changes Jul 5, 2021
View reviewed changes
Copy link
Contributor

@patil-suraj patil-suraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for fixing this!

Yes, the diagram should also be changed, but note that this is just for illustration.

@patil-suraj patil-suraj merged commit eceb104 into huggingface:master Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patil-suraj patil-suraj patil-suraj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@navjotts @patil-suraj