[WIP] Patch BigBird tokenization test #12653
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patches the BigBird integration test.
The core of the issue is that the
[MASK]
token is anAddedToken
withlstrip=True
. It, therefore, gobbles up the spaces on the left without getting a sentence piece underline.Therefore, when decoding, the internal sentence piece tokenizer is unaware that it should add a space in front of the
[MASK]
token.However, the original tokenizer does correctly decode with the space, so I believe there's an issue with our implementation.
@vasudevgupta7 do you know of the difference between the two implementations? Also cc @n1t0 and @SaulLu
Do not merge this as this isn't the correct fix :)