Wrong model is used in example, should be character instead of subword model #12676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the original Google repo for CANINE there was mixup in the model names in the README.md, which was fixed 2 weeks ago. Since this transformer model was created before, it probably resulted in wrong use in this example. s = subword, c = character
sgugger
reviewed
Jul 13, 2021
There was a problem hiding this comment.
Thanks for the PR! Let's wait for @NielsRogge to double-check the checkpoint name.
In the meantime, could you run make style on your branch to fix the formatting issue?
sgugger
reviewed
Jul 13, 2021
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
|
It's not easy to make a file the styler is happy with, haha. |
NielsRogge
reviewed
Jul 13, 2021
NielsRogge
approved these changes
Jul 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A canine.rst fix.
In the original Google repo for CANINE there was mixup in the model names in the README.md, which was fixed 2 weeks ago. Since this transformer model was created before, it probably resulted in wrong use in this example in canine.rst.
s = subword, c = character
Before submitting
Who can review?
@sgugger