Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate README.md to Traditional Chinese #12701

Merged
merged 8 commits into from
Jul 15, 2021

Conversation

qqaatw
Copy link
Contributor

@qqaatw qqaatw commented Jul 14, 2021

What does this PR do?

  1. Add README_zh-hant.md and links to direct users to each README.
  2. Some of terms in the file can be found at National Academy for Educational Research, an official website providing bilingual translations between English and Traditional Chinese.

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

cc @JetRunner

@qqaatw qqaatw changed the title [WIP] Add README_zh-tw.md [WIP] Translate README.md to Traditional Chinese Jul 14, 2021
README.md Outdated
<p>
<b>English</b> |
<a href="https://github.com/huggingface/transformers/blob/master/README_zh-hans.md">简体中文</a> |
<a href="https://github.com/huggingface/transformers/blob/master/README_zh-tw.md">繁體中文</a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend zh-hans and zh-hant instead of zh-cn and zh-tw to be more inclusive.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, that makes sense.

@qqaatw
Copy link
Contributor Author

qqaatw commented Jul 14, 2021

I'll ask my friends who are also native in Traditional Chinese, to help double check the terms in the files. So, we can ensure the accuracy of the translation.

@qqaatw qqaatw requested a review from JetRunner July 15, 2021 03:50
@qqaatw
Copy link
Contributor Author

qqaatw commented Jul 15, 2021

@JetRunner We have had the files checked. It is ready to merge if there is no other mistake.

@qqaatw qqaatw changed the title [WIP] Translate README.md to Traditional Chinese Translate README.md to Traditional Chinese Jul 15, 2021
@JetRunner
Copy link
Contributor

Cool! I'll give it a look then we are ready to merge.

Copy link
Contributor

@JetRunner JetRunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super cool. Thanks @qqaatw and your friends!

@JetRunner JetRunner merged commit 2349ac5 into huggingface:master Jul 15, 2021
@qqaatw qqaatw deleted the add-zh-tw-README branch July 16, 2021 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants