Preserve list type of additional_special_tokens in special_token_map
#12759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaulLu
changed the title
list type of additional_special_tokens in special_token_maplist type of additional_special_tokens in special_token_map
SaulLu
changed the title
list type of additional_special_tokens in special_token_maplist type of additional_special_tokens in special_token_map
Closed
4 tasks
sgugger
approved these changes
Jul 16, 2021
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #12598
As shown in the issue, the value associated with the
additional_special_tokenskey in thespecial_tokens_mapattribute of a tokenizer was of type string while its content is rather a list. This PR proposes a fix to keep the list type and adds tests.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. @LysandreJik and @sgugger, I would love to have a second look if there was ever a reason I missed that required the list to become a string.