Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SpeechEncoderDecoder & Speech2Text2 #13186
Add SpeechEncoderDecoder & Speech2Text2 #13186
Changes from 51 commits
f7197df
5f70018
f6d1d34
02e5b56
2ade5e3
12dc58e
b18ef83
a941700
34adbd9
00967fa
aea2f96
b947a5c
71079aa
75eaa47
11b5a4c
2ba6f5c
f956ea1
8c4570c
a5cea4b
14ab959
e871407
98c2245
5bc06a5
dfda5e2
3d03cc3
14b0b94
4c6354e
5a075c9
19106d1
ddbb5ae
a80511c
3bfc3a9
7ae54e4
5c85e11
a127254
d04fe22
e24a659
03f83fb
7dad652
88fce43
782462e
54ccc61
ea839ee
b3312dc
f772b2b
557dbdd
e6352a6
3421ae8
ef58aaf
3017421
571b50b
e584248
dcb9a38
f25a8c4
e9e6efd
348138f
aedd676
7185f7e
f23e257
745da1b
b54eaf6
b30bcaa
3ab86f5
5fbe61a
5fd96f6
652dbd8
ef9e0f7
e39a2ac
ae346c9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getattr(module, class_name)
can return an error ifNone
is not defined (cc @sgugger)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes but it should at this stage:
module
should haveclass_name
as an attribute. With this change you will make silent an error that should be raisde,There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case it was that
Speech2Text2Tokenizer
has no fast tokenizer. This means that the listTOKENIZER_MAPPING_NAMES.items()
is iterated forSpeech2Text2TokenizerFast
which then makesmodule_name
the last module in the list of which then throws an error. So I think for such cases we need theNone
here no?