Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimenting with adding proper get_config() and from_config() methods #14361

Merged
merged 3 commits into from
Nov 11, 2021
+21 −0
Merged

Experimenting with adding proper get_config() and from_config() methods #14361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
06c7238
Experimenting with adding proper get_config() and from_config() methods
Rocketknight1 Nov 10, 2021
07b522a
Adding a test for get/from config
Rocketknight1 Nov 10, 2021
5a424c1
Fix test for get/from config
Rocketknight1 Nov 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/transformers/modeling_tf_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -692,6 +692,13 @@ def __init__(self, config, *inputs, **kwargs):
self.config = config
self.name_or_path = config.name_or_path

def get_config(self):
return self.config

@classmethod
def from_config(cls, config, **kwargs):
return cls._from_config(config, **kwargs)

@classmethod
def _from_config(cls, config, **kwargs):
"""
Expand Down
14 changes: 14 additions & 0 deletions tests/test_modeling_tf_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,20 @@ def test_save_load(self):

self.assert_outputs_same(after_outputs, outputs)

def test_save_load_config(self):
config, inputs_dict = self.model_tester.prepare_config_and_inputs_for_common()

for model_class in self.all_model_classes:
model = model_class(config)
outputs = model(self._prepare_for_class(inputs_dict, model_class))

new_model = model_class.from_config(model.get_config())
_ = new_model(self._prepare_for_class(inputs_dict, model_class)) # Build model
new_model.set_weights(model.get_weights())
after_outputs = new_model(self._prepare_for_class(inputs_dict, model_class))

self.assert_outputs_same(after_outputs, outputs)

@tooslow
def test_graph_mode(self):
config, inputs_dict = self.model_tester.prepare_config_and_inputs_for_common()
Expand Down