-
Notifications
You must be signed in to change notification settings - Fork 27.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable automatic creation of decoder_input_ids given labels in TF #14469
Conversation
Added a way to automatically create the decoder_input_ids from the labels provided by the user
Hey @Carlosbogo, thanks for your contribution! I've pinged @patrickvonplaten to review your PR, but please note that Patrick if off until next Monday. Thanks for your patience! |
Thanks for the PR @Carlosbogo! I think we should also move the loss computation into the |
Hi @Carlosbogo, thanks for your contribution! Let me know if you are able to take into account the comment above. Thanks! |
Yeah, I think I can work on that. |
No it can be included in this PR. |
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
Hey @Carlosbogo, Hope you had a good start to 2022! Let me know if I can help with anything to get this PR merged :-) |
I'm really sorry for the delay: I had my university exams and couldn't find time to work on it. I'll try to do it as soon as possible. |
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
Added a way to automatically create the
decoder_input_ids
from thelabels
provided by the user theTFEncoderDecoderModel