Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable automatic creation of decoder_input_ids given labels in TF #14469

Closed
wants to merge 1 commit into from

Conversation

Carlosbogo
Copy link

Added a way to automatically create the decoder_input_ids from the labels provided by the user the TFEncoderDecoderModel

Added a way to automatically create the decoder_input_ids from the labels provided by the user
@LysandreJik
Copy link
Member

Hey @Carlosbogo, thanks for your contribution! I've pinged @patrickvonplaten to review your PR, but please note that Patrick if off until next Monday. Thanks for your patience!

@patrickvonplaten patrickvonplaten changed the title Closes #14397 Enable automatic creation of decoder_input_ids given labels in TF Nov 29, 2021
@patrickvonplaten
Copy link
Contributor

Thanks for the PR @Carlosbogo!

I think we should also move the loss computation into the TFEncoderDecoderModel class similar to how @NielsRogge has done it in this PR: #14139 . Right now the loss is computed in the decoder. However we should compute the loss directly in the TFEncoderDecoderModel class.

@NielsRogge
Copy link
Contributor

Hi @Carlosbogo, thanks for your contribution! Let me know if you are able to take into account the comment above.

Thanks!

@Carlosbogo
Copy link
Author

Yeah, I think I can work on that.
Should I create a new PR for it when I finish?

@NielsRogge
Copy link
Contributor

No it can be included in this PR.

@github-actions
Copy link

github-actions bot commented Jan 2, 2022

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@patrickvonplaten
Copy link
Contributor

Hey @Carlosbogo,

Hope you had a good start to 2022! Let me know if I can help with anything to get this PR merged :-)

@Carlosbogo
Copy link
Author

I'm really sorry for the delay: I had my university exams and couldn't find time to work on it. I'll try to do it as soon as possible.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot closed this Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants