Code

Deprecates AdamW and adds --optim#14744

Code

Merged

stas00 merged 55 commits intohuggingface:masterhuggingface/transformers:masterfrom manuelciosici:deprecate_adamwmanuelciosici/transformers:deprecate_adamwCopy head branch name to clipboardJan 13, 2022

+183-15

Commits

Commits on Dec 13, 2021

• Add AdamW deprecation warning

  manuelciosici

  committed
  32392af

  Copy full SHA for 32392af

• Add --optim to Trainer

  manuelciosici

  committed
  c637f37

  Copy full SHA for c637f37

• Update src/transformers/optimization.py

  Show description for b4d0b6d
  

  manuelciosici

  and

  sgugger

  authored
  b4d0b6d

  Copy full SHA for b4d0b6d

• Update src/transformers/optimization.py

  Show description for bcc2408
  

  manuelciosici

  and

  sgugger

  authored
  bcc2408

  Copy full SHA for bcc2408

• Update src/transformers/optimization.py

  Show description for 460eff4
  

  manuelciosici

  and

  sgugger

  authored
  460eff4

  Copy full SHA for 460eff4

• Update src/transformers/optimization.py

  Show description for 6dc78a6
  

  manuelciosici

  and

  sgugger

  authored
  6dc78a6

  Copy full SHA for 6dc78a6

• Update src/transformers/training_args.py

  Show description for 68dd581
  

  manuelciosici

  and

  sgugger

  authored
  68dd581

  Copy full SHA for 68dd581

• Update src/transformers/training_args.py

  Show description for 9560350
  

  manuelciosici

  and

  sgugger

  authored
  9560350

  Copy full SHA for 9560350

Commits on Dec 27, 2021

• Update src/transformers/training_args.py

  stas00

  authored
  01f1c7b

  Copy full SHA for 01f1c7b

• Merge remote-tracking branch 'origin/master' into deprecate_adamw

  stas00

  committed
  0c79a5f

  Copy full SHA for 0c79a5f

• fix style

  stas00

  committed
  7ec094f

  Copy full SHA for 7ec094f

Commits on Dec 29, 2021

• fix

  stas00

  committed
  1c9cccf

  Copy full SHA for 1c9cccf

Commits on Dec 30, 2021

• Regroup adamws together

  Show description for 9807d35
  

  manuelciosici

  and

  stas00

  committed
  9807d35

  Copy full SHA for 9807d35

• Change --adafactor to --optim adafactor

  manuelciosici

  committed
  7a063ab

  Copy full SHA for 7a063ab

• Use Enum for optimizer values

  manuelciosici

  committed
  d599a38

  Copy full SHA for d599a38

• fixup! Change --adafactor to --optim adafactor

  manuelciosici

  committed
  1f9210c

  Copy full SHA for 1f9210c

• fixup! Change --adafactor to --optim adafactor

  manuelciosici

  committed
  a80b39e

  Copy full SHA for a80b39e

• fixup! Change --adafactor to --optim adafactor

  manuelciosici

  committed
  fdf40b2

  Copy full SHA for fdf40b2

• Merge branch 'master' into deprecate_adamw

  manuelciosici

  authored
  d5dc69a

  Copy full SHA for d5dc69a

• fixup! Use Enum for optimizer values

  manuelciosici

  committed
  0acba0c

  Copy full SHA for 0acba0c

Commits on Dec 31, 2021

• Improved documentation for --adafactor

  Show description for 2b7d9dd
  

  manuelciosici

  and

  stas00

  authored
  2b7d9dd

  Copy full SHA for 2b7d9dd

• Add mention of no_deprecation_warning

  Show description for 7c3139a
  

  manuelciosici

  and

  stas00

  authored
  7c3139a

  Copy full SHA for 7c3139a

• Rename OptimizerOptions to OptimizerNames

  manuelciosici

  committed
  234f7d1

  Copy full SHA for 234f7d1

• Use choices for --optim

  manuelciosici

  committed
  1786d42

  Copy full SHA for 1786d42

• Move optimizer selection code to a function and add a unit test

  manuelciosici

  committed
  210ed37

  Copy full SHA for 210ed37

• Change optimizer names

  manuelciosici

  committed
  7e62da9

  Copy full SHA for 7e62da9

Commits on Jan 1, 2022

• Rename method

  Show description for 0e7f955
  

  manuelciosici

  and

  stas00

  authored
  0e7f955

  Copy full SHA for 0e7f955

• Rename method

  Show description for 12a9e37
  

  manuelciosici

  and

  stas00

  authored
  12a9e37

  Copy full SHA for 12a9e37

• Remove TODO comment

  Show description for c5853b0
  

  manuelciosici

  and

  stas00

  authored
  c5853b0

  Copy full SHA for c5853b0

• Rename variable

  Show description for d59aa52
  

  manuelciosici

  and

  stas00

  authored
  d59aa52

  Copy full SHA for d59aa52

• Rename variable

  Show description for e7ffd71
  

  manuelciosici

  and

  stas00

  authored
  e7ffd71

  Copy full SHA for e7ffd71

• Rename function

  manuelciosici

  committed
  b64fc03

  Copy full SHA for b64fc03

• Rename variable

  manuelciosici

  committed
  c5b5443

  Copy full SHA for c5b5443

• Parameterize the tests for supported optimizers

  manuelciosici

  committed
  91aff78

  Copy full SHA for 91aff78

• Refactor

  manuelciosici

  committed
  f3505db

  Copy full SHA for f3505db

• Attempt to make tests pass on CircleCI

  manuelciosici

  committed
  91c35f2

  Copy full SHA for 91c35f2

Commits on Jan 2, 2022

• Add a test with apex

  manuelciosici

  committed
  bcd8a0d

  Copy full SHA for bcd8a0d

• rework to add apex to parameterized; add actual train test

  stas00

  committed
  f8cb39c

  Copy full SHA for f8cb39c

• fix import when torch is not available

  stas00

  committed
  98f0f2f

  Copy full SHA for 98f0f2f

• fix optim_test_params when torch is not available

  stas00

  committed
  eba41bd

  Copy full SHA for eba41bd

• fix optim_test_params when torch is not available

  stas00

  committed
  aaee305

  Copy full SHA for aaee305

• re-org

  stas00

  committed
  071198c

  Copy full SHA for 071198c

• small re-org

  stas00

  committed
  182dac8

  Copy full SHA for 182dac8

• fix test_fused_adam_no_apex

  stas00

  committed
  2b46361

  Copy full SHA for 2b46361

Commits on Jan 12, 2022

• Update src/transformers/training_args.py

  Show description for 470a1d7
  

  manuelciosici

  and

  sgugger

  authored
  470a1d7

  Copy full SHA for 470a1d7

• Update src/transformers/training_args.py

  Show description for cb85474
  

  manuelciosici

  and

  sgugger

  authored
  cb85474

  Copy full SHA for cb85474

• Update src/transformers/training_args.py

  Show description for b2675f8
  

  manuelciosici

  and

  sgugger

  authored
  b2675f8

  Copy full SHA for b2675f8

• Remove .value from OptimizerNames

  manuelciosici

  committed
  1e8acec

  Copy full SHA for 1e8acec

• Rename optimizer strings s|--adam_|--adamw_|

  manuelciosici

  committed
  b32a194

  Copy full SHA for b32a194

• Also rename Enum options

  manuelciosici

  committed
  b839e80

  Copy full SHA for b839e80

• small fix

  stas00

  committed
  e73249c

  Copy full SHA for e73249c

• Fix instantiation of OptimizerNames. Remove redundant test

  manuelciosici

  committed
  7ac8dc0

  Copy full SHA for 7ac8dc0

• Use ExplicitEnum instead of Enum

  manuelciosici

  committed
  a2363cd

  Copy full SHA for a2363cd

• Add unit test with string optimizer

  manuelciosici

  committed
  ea02877

  Copy full SHA for ea02877

Commits on Jan 13, 2022

• Change optimizer default to string value

  manuelciosici

  committed
  ec92011

  Copy full SHA for ec92011