-
Notifications
You must be signed in to change notification settings - Fork 27.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keras metric callback #14867
Keras metric callback #14867
Conversation
I feel like it makes sense to test on three notebooks. (could be overkill so you decide)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the PR! I think there are a few points to polish but it should be ready to merge soon!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! You mentioned that this will only work with the latest version of TensorFlow, should there be a check to ensure that users trying to use this for earlier versions are not surprised when it doesn't work for their setup?
@LysandreJik Absolutely yes, that's getting added! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need to rebase on master and convert all docstrings to Markdown :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few last nits. And I think it's still missing the check for the minimum version of TensorFlow?
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
Hey, here's the unfinished Keras metric PR, co-authored with @merveenoyan!
Still to do:
generate()
is still very slow, but that's a separate PR 😨