Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests] Update speech diarization and WavLM tolerances #14902

Merged
merged 1 commit into from
Dec 23, 2021
Merged

[Tests] Update speech diarization and WavLM tolerances #14902

merged 1 commit into from
Dec 23, 2021

Conversation

anton-l
Copy link
Member

@anton-l anton-l commented Dec 23, 2021 •
edited
Loading

What does this PR do?

Turns out the difference in nn.GroupNorm between torch 1.9 and 1.10 (pytorch/pytorch#67907) is more noticeable than I initially expected. This PR updates the tolerances on some newer tests where the reference values were obtained on 1.10. When we update the CI env to 1.10, these can be safely reverted.

patrickvonplaten
patrickvonplaten approved these changes Dec 23, 2021
View reviewed changes
Copy link
Contributor

@patrickvonplaten patrickvonplaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@anton-l
Copy link
Member Author

anton-l commented Dec 23, 2021

FAILED examples/pytorch/test_examples.py::ExamplesTests::test_run_image_classification is unrelated, merging...

@anton-l anton-l merged commit ee55ea6 into huggingface:master Dec 23, 2021
@anton-l anton-l deleted the fix-diarization-tol branch December 23, 2021 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickvonplaten patrickvonplaten patrickvonplaten approved these changes

@LysandreJik LysandreJik Awaiting requested review from LysandreJik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anton-l @patrickvonplaten