Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use tqdm.auto in Pipeline docs #14920

Merged
merged 2 commits into from
Jan 10, 2022
Merged

Use tqdm.auto in Pipeline docs #14920

merged 2 commits into from
Jan 10, 2022

Conversation

bryant1410
Copy link
Contributor

It's better for e.g. notebook.

@bryant1410
Use tqdm.auto in Pipeline docs
246a6be 
It's better for e.g. notebook.
@LysandreJik LysandreJik requested a review from sgugger January 5, 2022 09:45
sgugger
sgugger reviewed Jan 10, 2022
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would leave it as "it sucks less" instead of "it's better" (not a fan of tqdm in notebooks ;-) ) but this is definitely an improvement, thanks for doing this!
Can you take care of the conflicts so we can merge the PR?

@sgugger sgugger merged commit f21bc42 into huggingface:master Jan 10, 2022
@sgugger
Copy link
Collaborator

sgugger commented Jan 10, 2022

Thanks again!

@bryant1410 bryant1410 deleted the patch-3 branch January 10, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgugger sgugger sgugger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bryant1410 @sgugger