[Tests] Speed up tokenizer tests #14964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickvonplaten
changed the title
|
|
||
| def get_tokenizer(self, **kwargs) -> CanineTokenizer: | ||
| return self.tokenizer_class.from_pretrained(self.tmpdirname, **kwargs) | ||
| tokenizer = self.tokenizer_class.from_pretrained(self.tmpdirname, **kwargs) | ||
| tokenizer._unicode_vocab_size = 1024 |
There was a problem hiding this comment.
This change alone gives a speed up of 2.5 minutes. The reason is that len(tokenizer) is by default > 1,000,000 for every Canine tokenizer and the 4 slowest tests encode every single character in the vocabulary in a for loop.
patrickvonplaten
changed the title
sgugger
approved these changes
Dec 28, 2021
|
|
||
| def get_tokenizer(self, **kwargs) -> CanineTokenizer: | ||
| return self.tokenizer_class.from_pretrained(self.tmpdirname, **kwargs) | ||
| tokenizer = self.tokenizer_class.from_pretrained(self.tmpdirname, **kwargs) | ||
| tokenizer._unicode_vocab_size = 1024 |
stevhliu
pushed a commit
to stevhliu/transformers
that referenced
this pull request
Jan 6, 2022
* speed up canine and mluke * speed up mbart and mbart50 toks * upload files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR speeds up the 7 slowest tokenizer tests significantly which should lead to a speed-up of ca. 3 minutes for every test that runs all tokenizer tests
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.