Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace assertion with exception #14970

Merged
merged 1 commit into from
Dec 29, 2021
Merged

Replace assertion with exception #14970

merged 1 commit into from
Dec 29, 2021

Conversation

jaketae
Copy link
Contributor

@jaketae jaketae commented Dec 29, 2021

What does this PR do?

Replaces assert with ValueError as per #12789.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@sgugger @patil-suraj

sgugger
sgugger approved these changes Dec 29, 2021
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this one!

@sgugger sgugger merged commit 04cddaf into huggingface:master Dec 29, 2021
@jaketae jaketae deleted the patch-1 branch December 29, 2021 15:21
stevhliu pushed a commit to stevhliu/transformers that referenced this pull request Jan 6, 2022
@jaketae
refactor: replace assert with ValueError (huggingface#14970)
391b440
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgugger sgugger sgugger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaketae @sgugger