Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resubmit changes after rebase to master #14982

Merged
merged 1 commit into from
Jan 7, 2022

Conversation

kct22aws
Copy link
Contributor

What does this PR do?

This PR proposes to add a new section to TorchScript documentation "Deploying HuggingFace TorchScript models on AWS using the Neuron SDK".

Fixes # issue 14425

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@philschmid , @LysandreJik

@kct22aws
Copy link
Contributor Author

kct22aws commented Dec 29, 2021

@philschmid @LysandreJik I carried over all my work from the previous serialization.rst to serialization.mdx file per rebase to master. Looking forward to the approval and merge to master branch.

@kct22aws
Copy link
Contributor Author

kct22aws commented Jan 5, 2022

Hi @LysandreJik @philschmid please review this PR and let me know of any suggestions. Thank you.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @kct22aws

@philschmid feel free to merge when you approve

Copy link
Member

@philschmid philschmid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @kct22aws

@philschmid philschmid merged commit f18c6fa into huggingface:master Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants