Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TFEncoderDecoder labels handling #14357 #15001

Merged

Conversation

ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Jan 1, 2022

What does this PR do?

Fixes #14357

Who can review?

@Rocketknight1

@ydshieh ydshieh changed the title Fix #14357 Fix TFEncoderDecoder labels handling #14357 Jan 1, 2022
@LysandreJik LysandreJik added the TensorFlow Anything TensorFlow label Jan 6, 2022
Copy link
Member

@Rocketknight1 Rocketknight1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Sorry for being slow - I'm still catching up on the Christmas backlog, but thank you for fixing this!

@Rocketknight1 Rocketknight1 merged commit 6820904 into huggingface:master Jan 12, 2022
@ydshieh ydshieh deleted the fix_tf_encoder_decoder_labels branch January 12, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TensorFlow Anything TensorFlow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TFEncoderDecoder not handling labels correctly
3 participants