Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SpeechEncoderDecoder] Fix from pretrained #15043

Conversation

patrickvonplaten
Copy link
Contributor

@patrickvonplaten patrickvonplaten commented Jan 5, 2022

What does this PR do?

Fixes an edge case that leads to failing CI for: tests/test_modeling_speech_encoder_decoder.py::Wav2Vec2BertModelTest::test_real_model_save_load_from_pretrained

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@patrickvonplaten patrickvonplaten merged commit 443fdaf into huggingface:master Jan 5, 2022
@patrickvonplaten
Copy link
Contributor Author

The other two VisionEncoderDecoderModel and EncoderDecoderModel were correct

@patrickvonplaten patrickvonplaten deleted the fix_speech_encoder_decoder branch January 5, 2022 15:55
stevhliu pushed a commit to stevhliu/transformers that referenced this pull request Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant