Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[examples/flax/language-modeling] set loglevel #15129

Merged
merged 1 commit into from
Jan 13, 2022
Merged

Conversation

stas00
Copy link
Contributor

@stas00 stas00 commented Jan 12, 2022

This PR sets the unset loglevel to a info like the rest of flax examples where it wasn't done so.

Fixes a report in #14909 (comment)

@patil-suraj, @sgugger

@stefan-it
Copy link
Collaborator

Thanks so much @stas00 , problem is solved now! Level is not correctly INFO during training!

@stas00
Copy link
Contributor Author

stas00 commented Jan 12, 2022

Thank you for confirming that, @stefan-it.

@sgugger
Copy link
Collaborator

sgugger commented Jan 13, 2022

Not the main person on the Flax examples so will let @patil-suraj or @patrickvonplaten chime in on the PR :-)

Copy link
Contributor

@patil-suraj patil-suraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@patil-suraj patil-suraj merged commit 762416f into master Jan 13, 2022
@patil-suraj patil-suraj deleted the fix-log-level branch January 13, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants