Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when code examples are improperly closed #15186

Merged
merged 1 commit into from
Jan 18, 2022
Merged

Conversation

sgugger
Copy link
Collaborator

@sgugger sgugger commented Jan 17, 2022

What does this PR do?

When an MDX file has a code sample that is not properly closed, the doc styler ends up removing part of that file. This PR addresses that problem by raising an error before the file is overwritten, so the user knows what's wrong and can fix it.

@sgugger sgugger requested a review from LysandreJik January 17, 2022 19:21
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice error!

@sgugger sgugger merged commit f6d3fee into master Jan 18, 2022
@sgugger sgugger deleted the style_mdx_error branch January 18, 2022 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants