Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when logs are empty because Keras has wiped them out of spite #15258

Merged
merged 1 commit into from
Jan 20, 2022

Conversation

Rocketknight1
Copy link
Member

In situations where the training history is empty, TF model card creation via model.create_model_card() or model.push_to_hub() no longer crashes.

@HuggingFaceDocBuilder
Copy link

Thank you for your PR! The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@Rocketknight1 Rocketknight1 merged commit 5782045 into master Jan 20, 2022
@Rocketknight1 Rocketknight1 deleted the tf_create_model_card_fix branch January 20, 2022 18:40
@HuggingFaceDocBuilder
Copy link

Great job merging this PR! the documentation will now be removed from the staging environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants