Remove Longformers from ONNX-supported models #15273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
lewtun
commented
Jan 21, 2022
| @@ -43,7 +43,7 @@ and are designed to be easily extendable to other architectures. | |||
|
|
|||
| Ready-made configurations include the following architectures: | |||
|
|
|||
| <!--This table is automatically generated by make style, do not fill manually!--> | |||
| <!--This table is automatically generated by `make fix-copies`, do not fill manually!--> | |||
There was a problem hiding this comment.
I took the liberty of updating this line to reflect the true make command
stevhliu
pushed a commit
to stevhliu/transformers
that referenced
this pull request
Feb 18, 2022
ManuelFay
pushed a commit
to ManuelFay/transformers
that referenced
this pull request
Mar 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR removes Longformer from the list of ONNX-supported models due to a current limitation in the supported ops in JIT - see issue #15217
This slipped through our unit tests because we didn't include
longformerin the list of models to be tested.Long term, we'll either need to wait for JIT to support the problematic ops or tweak the Longformer implementation.