Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deepspeed docs #15346

Merged
merged 1 commit into from
Jan 26, 2022
Merged

Fix deepspeed docs #15346

merged 1 commit into from
Jan 26, 2022

Conversation

ngoquanghuy99
Copy link
Contributor

What does this PR do?

Fixes typos and misspellings in deepspeed docs.

Who can review?

@sgugger @stas00 @LysandreJik

@HuggingFaceDocBuilder
Copy link

HuggingFaceDocBuilder commented Jan 26, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

sgugger
sgugger approved these changes Jan 26, 2022
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@sgugger sgugger merged commit 5d8b986 into huggingface:master Jan 26, 2022
stas00
stas00 reviewed Jan 26, 2022
View reviewed changes
Copy link
Contributor

@stas00 stas00 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for improving the language, @ngoquanghuy99

There are 2 places that need to be reverted as the proposed changes were incorrect there.

Not sure why the merge was rushed in, - @sgugger - what's the best way to fix this - revert the PR commit, then revert the 2 incorrect changes and then merge again? Thanks.

update: will be fixed by #15355

docs/source/main_classes/deepspeed.mdx Show resolved Hide resolved
docs/source/main_classes/deepspeed.mdx Show resolved Hide resolved
@sgugger
Copy link
Collaborator

sgugger commented Jan 26, 2022 •
edited
Loading

I'm sorry I overlooked mistakes in those two sentences. It's true those are not fixes, though the first one is not gramatically correct anyway.

Do as you wish to fix those, I'll make sure to stay very far away form the deepspeed file in the future.

stas00 added a commit that referenced this pull request Jan 26, 2022
@stas00
Revert "Fix deepspeed docs (#15346)"
c026bf2 
This reverts commit 5d8b986.
@stas00 stas00 mentioned this pull request Jan 26, 2022
Merged
@stas00
Copy link
Contributor

stas00 commented Jan 26, 2022 •
edited
Loading

I tried revert, but I thought it'd magically resume this PR and it didn't, so it'd be a bad workflow. So if I have to make a new PR, it's much simpler to just do a new PR with just the fixes: #15355

@ngoquanghuy99 ngoquanghuy99 deleted the patch-2 branch January 27, 2022 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stas00 stas00 stas00 left review comments

@sgugger sgugger sgugger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ngoquanghuy99 @HuggingFaceDocBuilder @sgugger @stas00