Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spanish translation of the file training.mdx #16047

Merged
merged 8 commits into from
Mar 14, 2022

Conversation

yharyarias
Copy link
Contributor

I made the translation of the training.mdx file in collaboration to the transformers/doc/ documentation, there I created a new folder called source_es where I hosted my training.mdx document translated to Spanish, contributing to the Spanish-speaking community.
forum

Approved by @omarespejel
Documentation: @sgugger

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Mar 10, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just reviewed the beginning but there are a lot of differences with the English version of this doc in terms of syntax used. Could you keep the same syntax for tips, links to other classes in the doc etc?

docs/source_es/Hugging.mdx Outdated Show resolved Hide resolved
docs/source_es/Hugging.mdx Outdated Show resolved Hide resolved
docs/source_es/Hugging.mdx Outdated Show resolved Hide resolved
docs/source_es/Hugging.mdx Outdated Show resolved Hide resolved
docs/source_es/Hugging.mdx Outdated Show resolved Hide resolved
docs/source_es/Hugging.mdx Outdated Show resolved Hide resolved
docs/source_es/Hugging.mdx Outdated Show resolved Hide resolved
@sgugger sgugger requested a review from LysandreJik March 10, 2022 15:57
@yharyarias
Copy link
Contributor Author

yharyarias commented Mar 10, 2022

@sgugger Of course, I will make the changes you indicate, leaving the syntax as per the original documentation. I have a question, I see that most of the conflicts are because of the links, do I leave all the links or remove them? I think these are important.

@omarespejel
Copy link
Contributor

As soon as the syntax is reviewed by @yharyarias, I will review the Spanish.

@omarespejel omarespejel self-requested a review March 10, 2022 16:09
@sgugger
Copy link
Collaborator

sgugger commented Mar 10, 2022

The links are automatically generated by our doc building tool. You should leave them as they are in the training.mdx file English version (for instance [Trainer]).

@yharyarias
Copy link
Contributor Author

Perfect! I'll follow your suggestions, thank you @sgugger 🙌🤗

@yharyarias
Copy link
Contributor Author

I just uploaded the changes you suggested @sgugger I'll be watching for your review.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot that's way better! You can remove the Hugging.mdx file from your PR.
I can't judge the translation itself but the format of the file is very good :-)

@omarespejel
Copy link
Contributor

Thanks! Will review the translation.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks for working on it @yharyarias!

Copy link
Contributor

@omarespejel omarespejel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Muy bueno @yharyarias! Thank you! I added some comments

docs/source_es/training.mdx Outdated Show resolved Hide resolved
docs/source_es/training.mdx Outdated Show resolved Hide resolved
docs/source_es/training.mdx Outdated Show resolved Hide resolved
docs/source_es/training.mdx Outdated Show resolved Hide resolved
docs/source_es/training.mdx Outdated Show resolved Hide resolved
docs/source_es/training.mdx Outdated Show resolved Hide resolved
docs/source_es/training.mdx Outdated Show resolved Hide resolved
docs/source_es/training.mdx Outdated Show resolved Hide resolved
docs/source_es/training.mdx Outdated Show resolved Hide resolved
docs/source_es/training.mdx Outdated Show resolved Hide resolved
@yharyarias yharyarias force-pushed the spanish_translation_training branch from d879c16 to 88ff60b Compare March 11, 2022 19:36
@yharyarias
Copy link
Contributor Author

I made the last changes suggested by @omarespejel , I think everything is ok, this is my first contribution and there will be more to come, I have loved collaborating with open source. Thank you very much 🤗 @sgugger @LysandreJik and @omarespejel

@omarespejel
Copy link
Contributor

Thanks, @yharyarias! There are still a couple of comments unresolved.

@omarespejel
Copy link
Contributor

omarespejel commented Mar 14, 2022

IMO it is good to go 👍 Thank you @yharyarias!

@sgugger sgugger merged commit efd6e9a into huggingface:master Mar 14, 2022
@sgugger
Copy link
Collaborator

sgugger commented Mar 14, 2022

Thanks again for your PR. Merging this but we will wait a little bit more to serve a doc in Spanish mainly:

  • to have a few more pages
  • to automatically redirect to English doc when the page is not available in Spanish.

I will put a comment here when the page is live (hopefully in a week or two!)

@yharyarias
Copy link
Contributor Author

@sgugger Thank you, of course I will continue to contribute, I'm currently working on the translation of another document to add to source_es.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants