-
Notifications
You must be signed in to change notification settings - Fork 27.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spanish translation of the file training.mdx #16047
Spanish translation of the file training.mdx #16047
Conversation
The documentation is not available anymore as the PR was closed or merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just reviewed the beginning but there are a lot of differences with the English version of this doc in terms of syntax used. Could you keep the same syntax for tips, links to other classes in the doc etc?
@sgugger Of course, I will make the changes you indicate, leaving the syntax as per the original documentation. I have a question, I see that most of the conflicts are because of the links, do I leave all the links or remove them? I think these are important. |
As soon as the syntax is reviewed by @yharyarias, I will review the Spanish. |
The links are automatically generated by our doc building tool. You should leave them as they are in the |
Perfect! I'll follow your suggestions, thank you @sgugger 🙌🤗 |
I just uploaded the changes you suggested @sgugger I'll be watching for your review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot that's way better! You can remove the Hugging.mdx
file from your PR.
I can't judge the translation itself but the format of the file is very good :-)
Thanks! Will review the translation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thanks for working on it @yharyarias!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Muy bueno @yharyarias! Thank you! I added some comments
d879c16
to
88ff60b
Compare
I made the last changes suggested by @omarespejel , I think everything is ok, this is my first contribution and there will be more to come, I have loved collaborating with open source. Thank you very much 🤗 @sgugger @LysandreJik and @omarespejel |
Thanks, @yharyarias! There are still a couple of comments unresolved. |
IMO it is good to go 👍 Thank you @yharyarias! |
Thanks again for your PR. Merging this but we will wait a little bit more to serve a doc in Spanish mainly:
I will put a comment here when the page is live (hopefully in a week or two!) |
@sgugger Thank you, of course I will continue to contribute, I'm currently working on the translation of another document to add to source_es. |
I made the translation of the training.mdx file in collaboration to the transformers/doc/ documentation, there I created a new folder called source_es where I hosted my training.mdx document translated to Spanish, contributing to the Spanish-speaking community.
forum
Approved by @omarespejel
Documentation: @sgugger