Configurable Relative Position Max. Distance #16155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
patil-suraj
approved these changes
Mar 15, 2022
sgugger
approved these changes
Mar 15, 2022
4 tasks
FrancescoSaverioZuppichini
pushed a commit
that referenced
this pull request
Mar 17, 2022
* Configurable Relative Position Max. Distance * fix missing config Co-authored-by: ahmed-elnaggar <ahmed.elnaggar@allianz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The relative attention on the T5 model can only configured with the number of buckets.
However, it has fixed max distance and can't be configured.
The current fixed max distance is working fine for text modality, but for much longer sequence use-cases, it has to be adjusted.
This pull request make it possible to configure the max distance in the relative attention.
Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@patrickvonplaten @sgugger @patil-suraj @LysandreJik