Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added spanish translation of quicktour.mdx #16158

Merged
merged 2 commits into from
Mar 15, 2022
Merged

Added spanish translation of quicktour.mdx #16158

merged 2 commits into from
Mar 15, 2022

Conversation

duedme
Copy link
Contributor

@duedme duedme commented Mar 14, 2022

Translation of quicktour.mdx into Spanish

I made the translation of quicktour.mdx into Spanish (fixes #15947). The document is located in the transformers/docs/source_es folder.

@omarespejel

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Mar 14, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Contributor

@omarespejel omarespejel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just some nits changes.

docs/source_es/quicktour.mdx Outdated Show resolved Hide resolved
docs/source_es/quicktour.mdx Outdated Show resolved Hide resolved
docs/source_es/quicktour.mdx Outdated Show resolved Hide resolved
docs/source_es/quicktour.mdx Outdated Show resolved Hide resolved
docs/source_es/quicktour.mdx Outdated Show resolved Hide resolved
docs/source_es/quicktour.mdx Outdated Show resolved Hide resolved
docs/source_es/quicktour.mdx Outdated Show resolved Hide resolved
docs/source_es/quicktour.mdx Outdated Show resolved Hide resolved
docs/source_es/quicktour.mdx Outdated Show resolved Hide resolved
docs/source_es/quicktour.mdx Outdated Show resolved Hide resolved
Co-authored-by: Omar U. Espejel <espejelomar@gmail.com>
@omarespejel
Copy link
Contributor

Thanks, @duedme! LGTM!

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!
Merging but we won't build the Spanish documentation just yet, we're waiting:

  • to have a few more pages in Spanish
  • to have the frontend default to the English version of pages when there is no Spanish translation yet (not implemented yet).

I will put a comment here once this page is live (hopefully in one or two weeks!)

@sgugger sgugger merged commit daa4944 into huggingface:master Mar 15, 2022
@duedme duedme deleted the quicktour_translation branch March 15, 2022 18:02
FrancescoSaverioZuppichini pushed a commit that referenced this pull request Mar 17, 2022
* Added spanish translation of quicktour.mdx

* Suggestions applied in the revision of the translation

Co-authored-by: Omar U. Espejel <espejelomar@gmail.com>

Co-authored-by: Omar U. Espejel <espejelomar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tranformers documentation translation to Spanish
4 participants