-
Notifications
You must be signed in to change notification settings - Fork 27.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix doc example #16448
Merged
patrickvonplaten
merged 2 commits into
huggingface:main
from
NielsRogge:fix_multi_label_doc_example
Apr 7, 2022
Merged
Fix doc example #16448
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This I think we should revert. Why wouldn't this work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@patrickvonplaten
I had a previous conversation with @NielsRogge on Slack.
He was using celine98/canine-s-finetuned-sst2, which has
"problem_type": "single_label_classification",
set in the config.Due to setting, in the following block,
transformers/src/transformers/models/canine/modeling_canine.py
Lines 1322 to 1329 in d55fcbc
the block for the condition
self.config.problem_type is None
is not run, and it continue to besingle_label_classification
, therefore the output is not compatible with the provided labels (which is to work with multiple labels here).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For Roberta,
cardiffnlp/twitter-roberta-base-emotion
is used, and theproblem_type
is not set in the config. Therefore, the model code is able to set it tomulti_label_classification
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy with "force-passing"
single_label_classification
as a flag here to overwrite default configsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean
multi_label_classification
? It's ok to keep this change?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is in the reversed direction:
celine98/canine-s-finetuned-sst2
has config is set tosingle_label_classification
)but this block in
PT_SEQUENCE_CLASSIFICATION_SAMPLE
transformers/src/transformers/utils/doc.py
Lines 269 to 282 in d77680e
is meant to be
multi_label_classification
. Seelabels = torch.nn.functional.one_hot
.That's why @NielsRogge needs to add
problem_type="multi_label_classification"
in the call tofrom_pretrained
.I will wait @NielsRogge joining this discussion, since he knows better the reason behind his change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, he is faster than my response ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see sorry yes you're right - ok to keep the change for me then!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nono all good this makes perfect sense, I misunderstood here.