TF: unpack inputs on Convbert, GPTJ, LED, and templates #16491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
gante
force-pushed
the
finalize_unpack_inputs
branch
from
ad75af7 to
0b85e4e
Compare
gante
commented
Mar 30, 2022
| @@ -376,6 +375,7 @@ def _prune_heads(self, heads_to_prune): | |||
| """ | |||
| raise NotImplementedError | |||
|
|
|||
| @unpack_inputs | |||
There was a problem hiding this comment.
It seems like this one was forgotten :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR implements the
@unpack_inputsdecorator on Convbert, GPTJ, LED, and templates, as per #16051.The diff is big, but the changes are all trivial:
input_processing()calls by the@unpack_inputsdecoratorinputs["foo"]byfoo(thank god regex exists 🙏 )Only one PR remains to close the issue linked above -- implement the change in the encoder_decoder architectures. I've decided to create a separate PR for that one as the changes are not as trivial, and will require a review from a core maintainer.