don't load state_dict twice when using low_cpu_mem_usage in from_pretrained #16602
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In
from_pretrained
thestate_dict
is loaded twice whenlow_cpu_mem_usage
isTrue
, which is not required since thestate_dict
is already loaded before as we can here.transformers/src/transformers/modeling_utils.py
Lines 1795 to 1797 in 21decb7
So, it's fine to remove it there because when is_sharded=False, the state_dict is loaded at line 1797