Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix seq2seq doc tests #16606

Merged
merged 5 commits into from
Apr 6, 2022
Merged

Fix seq2seq doc tests #16606

merged 5 commits into from
Apr 6, 2022

Conversation

patil-suraj
Copy link
Contributor

@patil-suraj patil-suraj commented Apr 5, 2022 •
edited
Loading

What does this PR do?

This PR fixes the doc tests for se2seq models (BART, mBART, BigBirdPegasus, PLBart).

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Apr 5, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@patil-suraj patil-suraj changed the title [wip] Fix se2seq doc tests Fix se2seq doc tests Apr 5, 2022
@patil-suraj patil-suraj changed the title Fix se2seq doc tests Fix seq2seq doc tests Apr 5, 2022
ydshieh
ydshieh approved these changes Apr 5, 2022
View reviewed changes
Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

Run locally and all tests pass!

src/transformers/models/bigbird_pegasus/modeling_bigbird_pegasus.py Show resolved Hide resolved
src/transformers/models/plbart/modeling_plbart.py Outdated Show resolved Hide resolved
patrickvonplaten
patrickvonplaten approved these changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@patrickvonplaten patrickvonplaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge!

@patil-suraj patil-suraj merged commit a2b7d19 into huggingface:main Apr 6, 2022
@patil-suraj patil-suraj deleted the doctest-fix-s2s-tests branch April 6, 2022 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickvonplaten patrickvonplaten patrickvonplaten approved these changes

@ydshieh ydshieh ydshieh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@patil-suraj @HuggingFaceDocBuilderDev @ydshieh @patrickvonplaten