Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate model templates #17062

Merged
merged 2 commits into from
May 4, 2022
Merged

Deprecate model templates #17062

merged 2 commits into from
May 4, 2022

Conversation

sgugger
Copy link
Collaborator

@sgugger sgugger commented May 3, 2022

What does this PR do?

This PR officially deprecates the model templates and moves their test to a daily scheduled job.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented May 3, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@patrickvonplaten
Copy link
Contributor

Thanks a lot!

LysandreJik
LysandreJik approved these changes May 3, 2022
View reviewed changes
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This will still run on the main branch though, is that what you had in mind? If not, you should remove the push directive on line 4.

@sgugger sgugger merged commit bb8d405 into main May 4, 2022
@sgugger sgugger deleted the deprecate_templates branch May 4, 2022 13:36
nandwalritik pushed a commit to nandwalritik/transformers that referenced this pull request May 4, 2022
@sgugger @nandwalritik
Deprecate model templates (huggingface#17062)
41da429 
* Deprecate model templates

* Address review comments
nandwalritik pushed a commit to nandwalritik/transformers that referenced this pull request May 4, 2022
@sgugger @nandwalritik
Deprecate model templates (huggingface#17062)
688b12b 
* Deprecate model templates

* Address review comments
Narsil pushed a commit to Narsil/transformers that referenced this pull request May 12, 2022
@sgugger @Narsil
Deprecate model templates (huggingface#17062)
7587a82 
* Deprecate model templates

* Address review comments
elusenji pushed a commit to elusenji/transformers that referenced this pull request Jun 12, 2022
@sgugger @elusenji
Deprecate model templates (huggingface#17062)
4446f73 
* Deprecate model templates

* Address review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LysandreJik LysandreJik LysandreJik approved these changes

@patrickvonplaten patrickvonplaten patrickvonplaten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sgugger @HuggingFaceDocBuilderDev @patrickvonplaten @LysandreJik