Make sure telemetry arguments are not returned as unused kwargs #17063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgugger
commented
May 3, 2022
| @@ -356,7 +356,7 @@ def test_repo_versioning_before(self): | |||
| ) | |||
| self.assertEqual(new_configuration.hidden_size, 2) | |||
| # This checks `_configuration_file` ia not kept in the kwargs by mistake. | |||
| self.assertDictEqual(kwargs, {"_from_auto": True}) | |||
| self.assertDictEqual(kwargs, {}) | |||
There was a problem hiding this comment.
This will actually give us a test for this :-)
|
The documentation is not available anymore as the PR was closed or merged. |
nandwalritik
pushed a commit
to nandwalritik/transformers
that referenced
this pull request
May 4, 2022
…ingface#17063) * Make sure telemetry arguments are not returned as unused kwargs * Fix test
nandwalritik
pushed a commit
to nandwalritik/transformers
that referenced
this pull request
May 4, 2022
…ingface#17063) * Make sure telemetry arguments are not returned as unused kwargs * Fix test
Narsil
pushed a commit
to Narsil/transformers
that referenced
this pull request
May 12, 2022
…ingface#17063) * Make sure telemetry arguments are not returned as unused kwargs * Fix test
elusenji
pushed a commit
to elusenji/transformers
that referenced
this pull request
Jun 12, 2022
…ingface#17063) * Make sure telemetry arguments are not returned as unused kwargs * Fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As pointed out in #17056, the telemetry arguments are sometimes returned as unused kwargs. This is because
AutoConfig.from_pretrainedends up using thefrom_dictmethod and not thefrom_pretrainedmethod in most cases, and thatfrom_dictmethod does not treat those kwargs.Fixes #17056