Train args defaulting None marked as Optional #17156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
sgugger
approved these changes
May 10, 2022
Narsil
pushed a commit
to Narsil/transformers
that referenced
this pull request
May 12, 2022
Co-authored-by: Dom Miketa <dmiketa@exscientia.co.uk>
elusenji
pushed a commit
to elusenji/transformers
that referenced
this pull request
Jun 12, 2022
Co-authored-by: Dom Miketa <dmiketa@exscientia.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #16701 by marking every
TrainingArgumentsargumentOptionalif it currently defaults toNone. Other applications which depend on static type hinting will no longer be confused by arguments defaulting toNonealthough their declared type isbool.Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@sgugger