Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing fsdp autowrap functionality #17922

Merged
merged 5 commits into from
Jul 1, 2022
Merged

fixing fsdp autowrap functionality #17922

merged 5 commits into from
Jul 1, 2022

Conversation

pacman100
Copy link
Contributor

What does this PR do?

  1. PyTorch has renamed default_auto_wrap_policy to size_based_auto_wrap_policy. This PR updates the same.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

@pacman100 pacman100 requested a review from sgugger June 28, 2022 11:43
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 28, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

sgugger
sgugger reviewed Jun 28, 2022
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. I think we should proceed differently to still support the previous nightly builds, and import the old name as the new name then.

@pacman100
Copy link
Contributor Author

Thanks for the fix. I think we should proceed differently to still support the previous nightly builds, and import the old name as the new name then.

Hello, I have updated the version requirement to the stable torch version 1.12.0 and this version has the updated name for the function. The support in 1.11.0 couldn't allow for saving model when using FSDP.

@pacman100 pacman100 requested a review from sgugger July 1, 2022 04:31
sgugger
sgugger approved these changes Jul 1, 2022
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thnaks!

@pacman100 pacman100 merged commit 462b7f3 into main Jul 1, 2022
@pacman100 pacman100 deleted the smangrul/fsdp-fix-autowrap branch July 1, 2022 14:10
viclzhu pushed a commit to viclzhu/transformers that referenced this pull request Jul 18, 2022
@pacman100 @viclzhu
fixing fsdp autowrap functionality (huggingface#17922)
19742ad 
* fixing fsdp autowrap functionality

* update version and quality

* update torch version to latest stable version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgugger sgugger sgugger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pacman100 @HuggingFaceDocBuilderDev @sgugger