Ensure PT model is in evaluation mode and lightweight forward pass done #17970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgugger
approved these changes
Jun 30, 2022
| @@ -270,9 +270,13 @@ def run(self): | |||
|
|
|||
| # Load models and acquire a basic input compatible with the model. | |||
| pt_model = pt_class.from_pretrained(self._local_dir) | |||
| pt_model.eval() | |||
There was a problem hiding this comment.
If you don't get a model in eval mode with from_pretrained, then it's a bug.
(Not saying we shouldn't be safe, but this line shouldn't be necessary.)
|
The documentation is not available anymore as the PR was closed or merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small update to the
pt-to-tfCLI. Sets the pytorch model into evaluate model and usesno_gradcontext to make the memory requirements lighter.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.