Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix codeparrot deduplication - ignore whitespaces #18023

Merged
merged 4 commits into from
Jul 28, 2022

Conversation

loubnabnl
Copy link
Contributor

The current exact deduplication doesn't ignore whitespaces before computing the hash.

@loubnabnl loubnabnl requested a review from lvwerra July 5, 2022 10:19
Copy link
Member

@lvwerra lvwerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can you add some documentation on how the deduplication handles whitespaces?

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jul 28, 2022

The documentation is not available anymore as the PR was closed or merged.

@loubnabnl loubnabnl merged commit 286a18f into huggingface:main Jul 28, 2022
oneraghavan pushed a commit to oneraghavan/transformers that referenced this pull request Sep 26, 2022
* ignore whitspaces for hash

* reformat code

* Update README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants