Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin rouge_score #18247

Merged
merged 7 commits into from
Sep 1, 2022
Merged

Pin rouge_score #18247

merged 7 commits into from
Sep 1, 2022

Conversation

albertvillanova
Copy link
Member

What does this PR do?

Temporarily pin rouge_score (to avoid latest version 0.7.0) until the issue is fixed on their side:

See:

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jul 22, 2022

The documentation is not available anymore as the PR was closed or merged.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@LysandreJik
Copy link
Member

Hey @albertvillanova, sorry for missing this! Should this be merged? Should we replace by !=0.7.0 so that we're still compatible with newer versions?

@albertvillanova
Copy link
Member Author

They made several failed releases until they got to fix the error... Let me update this PR with all the versions to be avoided.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a lot of incompatibilities 😅

Feel free to merge when happy @albertvillanova, thanks for your PR!

@albertvillanova
Copy link
Member Author

@LysandreJik there is a non-passing test though...

@LysandreJik
Copy link
Member

Hmmm weird, it seems like it passed when it was <0.07 here (installing version v0.0.4), but not after setting rouge-score!=0.0.7,!=0.0.8,!=0.1,!=0.1.1 (installing version 1.2.0).

I see that when installing rouge-score version v1.2.0, it was installing rouge-score using a legacy approach:

Using legacy 'setup.py install' for rouge-score, since package 'wheel' is not installed.

Could this be the cause of the failure? If you put <0.7 once again, does it pass the test?

@albertvillanova
Copy link
Member Author

albertvillanova commented Aug 24, 2022

The test does not pass now either with rouge-score<0.0.7, @LysandreJik.

But it passed when I opened this PR: see 4e7a46d

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error was fixed on main, so let's merge it like that!

@LysandreJik LysandreJik merged commit fafbb57 into main Sep 1, 2022
@LysandreJik LysandreJik deleted the albertvillanova-patch-1 branch September 1, 2022 10:04
oneraghavan pushed a commit to oneraghavan/transformers that referenced this pull request Sep 26, 2022
* Pin rouge_score

* Pin also in dependency_versions_table

* Update excluded versions

* Revert "Update excluded versions"

This reverts commit 0d0362d.

* Revert "Revert "Update excluded versions""

This reverts commit 66c47af.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants