-
Notifications
You must be signed in to change notification settings - Fork 27.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin rouge_score #18247
Pin rouge_score #18247
Conversation
The documentation is not available anymore as the PR was closed or merged. |
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
Hey @albertvillanova, sorry for missing this! Should this be merged? Should we replace by |
They made several failed releases until they got to fix the error... Let me update this PR with all the versions to be avoided. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a lot of incompatibilities 😅
Feel free to merge when happy @albertvillanova, thanks for your PR!
@LysandreJik there is a non-passing test though... |
Hmmm weird, it seems like it passed when it was <0.07 here (installing version v0.0.4), but not after setting I see that when installing
Could this be the cause of the failure? If you put |
This reverts commit 0d0362d.
The test does not pass now either with But it passed when I opened this PR: see 4e7a46d |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The error was fixed on main
, so let's merge it like that!
What does this PR do?
Temporarily pin
rouge_score
(to avoid latest version 0.7.0) until the issue is fixed on their side:See: