Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Owlvit docs test #18257

Merged
merged 95 commits into from
Jul 26, 2022
Merged

Owlvit docs test #18257

merged 95 commits into from
Jul 26, 2022

Conversation

alaradirik
Copy link
Contributor

@alaradirik alaradirik commented Jul 22, 2022 •
edited
Loading

  • Fixes a typo in OwlViTForObjectDetection forward function docs: transformers/models/owlvit/modeling_owlvit.py
  • Adds docs test for OWL-ViT
  • Makes OwlViTFeatureExtractor.post_process callable from OwlViTProcessor
  • Improves code examples to demonstrate how to use the post_process method

alaradirik and others added 30 commits June 16, 2022 16:16
@alaradirik
add owlvit model skeleton
bd08fd0
@alaradirik
add class and box predictor heads
cff1597
@alaradirik
convert modified flax clip to pytorch
3fb93b5
@alaradirik
fix box and class predictors
6b80535
@alaradirik
add OwlViTImageTextEmbedder
a57c8c3
@alaradirik
convert class and box head checkpoints
298acc4
@alaradirik
convert image text embedder checkpoints
aa62cf3
@alaradirik
add object detection head
eed0c47
@alaradirik
fix bugs
9dfae2e
@alaradirik
update conversion script
12b3554
@alaradirik
update conversion script
6e88bdc
@alaradirik
fix q,v,k,out weight conversion conversion
d342a81
@alaradirik
add owlvit object detection output
5a15207
@alaradirik
fix bug in image embedder
6adfabd
@alaradirik
fix bugs in text embedder
ef94525
@alaradirik
fix positional embeddings
d4315a3
@alaradirik
fix bug in inference mode vision pooling
e385e33
@alaradirik
update docs, init tokenizer and processor files
985025e
@alaradirik
support batch processing
6653465
@alaradirik
add OwlViTProcessor
5e6e8b4
@alaradirik
remove merge conflicts
2e63dde
@alaradirik
Merge branch 'huggingface:main' into owlvit
79083c5
@alaradirik
readd owlvit imports
35f9f31
@alaradirik
fix bug in OwlViTProcessor imports
78b7837
@alaradirik
fix bugs in processor
d919422
@alaradirik
update docs
4635688
@alaradirik
fix bugs in processor
8a1c825
@alaradirik
update owlvit docs
363f4d5
@alaradirik
add OwlViTFeatureExtractor
161cb2a
@alaradirik
style changes, add postprocess method to feature extractor
58aa6ce
@alaradirik alaradirik requested a review from NielsRogge July 22, 2022 13:22
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jul 22, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@alaradirik alaradirik requested a review from NielsRogge July 25, 2022 12:12
NielsRogge
NielsRogge approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@NielsRogge NielsRogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just wondering why there are 90+ commits

@alaradirik
Copy link
Contributor Author

LGTM! Just wondering why there are 90+ commits

That was my mistake, I merged the owlvit branch of my forked transformers repo with the main and created this branch. I squashed the commits on the main but don't know how to fix this one.

@LysandreJik
Copy link
Member

Let me know if you'd like some help to squash the commits of this PR @alaradirik!

@alaradirik alaradirik merged commit 002915a into huggingface:main Jul 26, 2022
oneraghavan pushed a commit to oneraghavan/transformers that referenced this pull request Sep 26, 2022
@alaradirik @oneraghavan
Owlvit docs test (huggingface#18257)
3515274 
* fix docs and add owlvit docs test

* fix minor bug in post_process, add to processor

* improve owlvit code examples

* fix hardcoded image size
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NielsRogge NielsRogge NielsRogge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alaradirik @HuggingFaceDocBuilderDev @LysandreJik @NielsRogge