Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing tests for XLA generation in TF #18298

Merged
merged 2 commits into from
Aug 3, 2022

Conversation

dsuess
Copy link
Contributor

@dsuess dsuess commented Jul 26, 2022

What does this PR do?

This PR fixes the failing tests for text generation in XLA mentioned in #17935. The issue was that the failing models had additional settings limiting the sequence length, which weren’t updated when creating the config-objects for the tests.

Fixes # 17935

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@gante @LysandreJik

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jul 26, 2022

The documentation is not available anymore as the PR was closed or merged.

@gante
Copy link
Member

gante commented Aug 3, 2022

Hi @dsuess! Thank you so much for looking into this -- I can confirm that the tests are passing after these changes.

This implies two things:

  1. The models are indeed XLA-ready, so I will tick their boxes in the original issue TF: XLA generation not working properly in some models #17935
  2. The tests were failing due to poor model parametrization at test time -- I will open a follow-up PR to fix them

@gante gante requested a review from sgugger August 3, 2022 13:38
@gante
Copy link
Member

gante commented Aug 3, 2022

cc @sgugger (with these changes the XLA tests will run instead of being skipped, but the root cause still needs to be addressed to avoid this ad hoc logic, see my comment above)

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@sgugger sgugger merged commit 8fb7c90 into huggingface:main Aug 3, 2022
oneraghavan pushed a commit to oneraghavan/transformers that referenced this pull request Sep 26, 2022
* Fix failing test_xla_generate_slow tests

* Fix failing speech-to-text xla_generate tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants