Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sentencepiece shouldn't be required for the fast LayoutXLM tokenizer #18320

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

LysandreJik
Copy link
Member

This PR duplicates the LAYOUTXLM_ENCODE_KWARGS_DOCSTRING variable which is currently imported from a file that is behind a sentencepiece requirement.

@LysandreJik LysandreJik requested a review from sgugger July 27, 2022 12:59
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jul 27, 2022

The documentation is not available anymore as the PR was closed or merged.

@LysandreJik LysandreJik merged commit 5c5676c into main Jul 27, 2022
@LysandreJik LysandreJik deleted the sentencepiece-fast-layoutxlm branch July 27, 2022 13:09
oneraghavan pushed a commit to oneraghavan/transformers that referenced this pull request Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants