Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sacremoses sof dependency for Transformers XL #18321

Merged
merged 2 commits into from
Jul 27, 2022

Conversation

sgugger
Copy link
Collaborator

@sgugger sgugger commented Jul 27, 2022

What does this PR do?

sacremoses is not a hard dependency of Transformers, but is used without protection the tokenization module of Transformers XL. This PR fixes that.

@sgugger sgugger requested a review from LysandreJik July 27, 2022 13:04
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful, thank you!

@sgugger sgugger changed the title Fix sacremoses sof dependency for Transofmers XL Fix sacremoses sof dependency for Transfomers XL Jul 27, 2022
@sgugger sgugger changed the title Fix sacremoses sof dependency for Transfomers XL Fix sacremoses sof dependency for Transformers XL Jul 27, 2022
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jul 27, 2022

The documentation is not available anymore as the PR was closed or merged.

@sgugger sgugger merged commit 0077360 into main Jul 27, 2022
@sgugger sgugger deleted the fix_sacremoses_transfo_xl branch July 27, 2022 13:37
oneraghavan pushed a commit to oneraghavan/transformers that referenced this pull request Sep 26, 2022
* Fix sacremoses sof dependency for Transofmers XL

* Add function to the submodule init
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants